upstream snmalloc-rs as part of snmalloc#744
Closed
SchrodingerZhu wants to merge 2 commits intomicrosoft:mainfrom
Closed
upstream snmalloc-rs as part of snmalloc#744SchrodingerZhu wants to merge 2 commits intomicrosoft:mainfrom
SchrodingerZhu wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
|
is this still in progress? |
Collaborator
Author
|
I am still okay with this and I can continue contributing to the rust part at upstream. If this is the decided approach to go, I will archive the downstream and put a pointer to upstream in its README. |
Collaborator
Author
|
Pros and cons on top of my head: Pros
Cons
Some other issues: Maybe it is better to unify the versions in some future releases. |
Contributor
|
Additional pro: |
You could look into git subtree merge if you want to preserve the history. There are some tangentially applicable docs on that in https://docs.freebsd.org/en/articles/committers-guide/#vendor-import-git |
Merged
Collaborator
Author
|
superseded by #801 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.